[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/7] regedit: Use a helper function to allocate memory and check for a valid pointer
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2017-07-27 7:37:18
Message-ID: 877eyucoup.fsf () winehq ! org
[Download RAW message or body]

Hugh McMaster <hugh.mcmaster@outlook.com> writes:

> On Thursday, 27 July 2017 2:41 AM, Alexandre Julliard wrote:
>> That's not the standard heap_alloc(), so a different name would be
>> preferable. I'd suggest heap_xalloc by analogy with xmalloc.
>
> "Standard" would be a function just returning HeapAlloc(...), right?

Yes, the one that we use in many places, and that Michael is going to
move to a global header any day now ;-)

> By the way, regedit should exit(0), but perhaps exit(1) - as in the patch -
> is still more appropriate for allocation failure?

Sure.

-- 
Alexandre Julliard
julliard@winehq.org



[prev in list] [next in list] [prev in thread] [next in thread]