[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 3/4 v2] gdiplus: Add partial support for GdipDrawImagePointsRect on metafile
From:       Vincent Povirk <madewokherd () gmail ! com>
Date:       2017-06-29 17:51:26
Message-ID: CAG_NDKqxHtaPcZNfJAq0nyeWLh4Gr8y4zg4jDZR710c+QKwP8w () mail ! gmail ! com
[Download RAW message or body]

+    draw_image_record->SrcRect.Width = units_to_pixels(srcwidth,
srcUnit, metafile->image.xres);;
+    draw_image_record->SrcRect.Height = units_to_pixels(srcheight,
srcUnit, metafile->image.yres);;

One semicolon is probably enough.

I think we should put a little more effort into object management up front.

I would start it by having the Add*Object functions return an id to
the caller, and adding a ReleaseObjects function to indicate that the
current objects are no longer needed. For now, we could just implement
this as a counter that we reset to 0.



[prev in list] [next in list] [prev in thread] [next in thread]