[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [v5 1/3] d3dx9: Remove redundant parameter size check in set_constants().
From:       Matteo Bruni <matteo.mystral () gmail ! com>
Date:       2017-06-27 18:32:21
Message-ID: CABvNrtNGfivwePxPd3YVfLkpsXneWv_3Zk6iHx6SDOREQ8XeXQ () mail ! gmail ! com
[Download RAW message or body]

2017-06-22 15:11 GMT+02:00 Paul Gofman <gofmanp@gmail.com>:
> Signed-off-by: Paul Gofman <gofmanp@gmail.com>
> ---
> v5:
> - Removed assert for parameter data length. The check for constant size not \
> exceeding parameter size is in the next patch. Otherwise the code would be changed \
> right in the next patch after modifying get_const_upload_info(), while before that \
> the check is redundant.

Yeah, it would have been slightly preferable with the check in a
separate patch before this one. The check would have been redundant in
practice but that's a bit of an "implementation detail".

Certainly not a big deal though.


[prev in list] [next in list] [prev in thread] [next in thread]