[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 3/4] quartz: fix crash in FilterGraph2_Render
From:       Andrew Eikum <aeikum () codeweavers ! com>
Date:       2017-05-31 14:32:31
Message-ID: 20170531143230.GE2524 () foghorn ! codeweavers ! com
[Download RAW message or body]

Can you add a test for this?

Andrew

On Thu, May 25, 2017 at 04:54:49PM +0200, Miklós Máté wrote:
> Note: there are a lot of other places as well where the null pointer handling
> is present in the msdn docs but missing in wine.
> 
> Signed-off-by: Miklós Máté <mtmkls@gmail.com>
> ---
>  dlls/quartz/filtergraph.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/dlls/quartz/filtergraph.c b/dlls/quartz/filtergraph.c
> index a143b05d83..e26eb199c8 100644
> --- a/dlls/quartz/filtergraph.c
> +++ b/dlls/quartz/filtergraph.c
> @@ -1279,6 +1279,9 @@ static HRESULT WINAPI FilterGraph2_Render(IFilterGraph2 *iface, IPin *ppinOut)
>  
>      TRACE("(%p/%p)->(%p)\n", This, iface, ppinOut);
>  
> +    if (!ppinOut)
> +        return E_POINTER;
> +
>      if (TRACE_ON(quartz))
>      {
>          PIN_INFO PinInfo;
> -- 
> 2.11.0
> 
> 
> 



[prev in list] [next in list] [prev in thread] [next in thread]