[prev in list] [next in list] [prev in thread] [next in thread]
List: wine-devel
Subject: Re: [PATCH 3/4] mfplat: Implement MFTEnum.
From: Nikolay Sivov <bunglehead () gmail ! com>
Date: 2017-04-28 5:46:34
Message-ID: 3b866f80-dee0-d613-3661-874cee5c98e9 () gmail ! com
[Download RAW message or body]
On 28.04.2017 7:28, Alistair Leslie-Hughes wrote:
> + for (i = 0; i < size / sizeof(GUID); i += 2)
> + {
> + if (!memcmp(&guids[i], &type->guidMajorType, sizeof(GUID)) &&
> + !memcmp(&guids[i+1], &type->guidSubtype, sizeof(GUID)))
> + {
> + ret = TRUE;
> + break;
> + }
> + }
IsEqualGUID could be used instead.
> +HRESULT WINAPI MFTEnum(GUID category, UINT32 flags, MFT_REGISTER_TYPE_INFO *input_type,
> + MFT_REGISTER_TYPE_INFO *output_type, IMFAttributes *attributes,
> + CLSID **pclsids, UINT32 *pcount)
I think it's better to print a fixme for non-zero flags and attributes,
and use TRACE otherwise.
> + if (RegOpenKeyW(HKEY_LOCAL_MACHINE, categories_keyW, &hcategory))
> + return E_FAIL;
> +
> + GUIDToString(buffer, &category);
> +
> + ret = RegOpenKeyW(hcategory, buffer, &hlist);
> + RegCloseKey(hcategory);
> + if (ret) return E_FAIL;
This probably could be replaced with a single RegOpenKeyW().
> + PVOID tmp;
Why void*?
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic