[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/3] dwrite: Fix name section strings lookup
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2017-04-27 15:08:28
Message-ID: 18af0b4b-f8de-370f-9473-36713499d56c () gmail ! com
[Download RAW message or body]

On 27.04.2017 17:54, Piotr Caban wrote:
> On 04/27/17 16:52, Nikolay Sivov wrote:
>> On 27.04.2017 17:03, Piotr Caban wrote:
>>> Signed-off-by: Piotr Caban <piotr@codeweavers.com>
>>> ---
>>>  dlls/dwrite/opentype.c | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>>
>>
>> The problem with this patch is that we want to continue and add as many
>> strings for different locales as possible. So the condition should set
>> 'exists' to TRUE after first pair was added successfully and never touch
>> it after.
>>
>>
> Yes, sorry, this patch is incorrect. I think that it would be nice to
> not fail in hard way if any of the names were decoded. Also I'll check
> why name decoding fails here.

Yes, it shouldn't fail if only some records failed, it does that now
because variable is overwritten on every iteration.

> 
> Thanks,
> Piotr




[prev in list] [next in list] [prev in thread] [next in thread]