[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 3/3] dwrite: Fix EUDC font collection use after free issue
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2017-04-27 14:40:17
Message-ID: 300b4074-76cf-939b-0c5b-daae26f56b48 () gmail ! com
[Download RAW message or body]

On 27.04.2017 17:04, Piotr Caban wrote:
> 
> Without this patch factory_detach_fontcollection incorrectly releases
> factory reference.
> 
> Signed-off-by: Piotr Caban <piotr@codeweavers.com>
> ---
>  dlls/dwrite/dwrite_private.h |  2 +-
>  dlls/dwrite/font.c           |  6 ++++--
>  dlls/dwrite/main.c           | 15 ++++++++-------
>  3 files changed, 13 insertions(+), 10 deletions(-)
> 

This makes sense, thanks. Please add some test for that in
test_GetEudc*, similar to what test_object_lifetime() does in the
beginning - testing that collection gets factory reference, but only once.



[prev in list] [next in list] [prev in thread] [next in thread]