[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] wmvcore: Add WMReader stubs.
From:       Andrew Eikum <aeikum () codeweavers ! com>
Date:       2017-03-31 20:04:24
Message-ID: 20170331200424.GS22656 () foghorn ! codeweavers ! com
[Download RAW message or body]

On Thu, Mar 30, 2017 at 05:30:09PM -0500, Jefferson Carpenter wrote:
> Do FIXME statements need to print out the passed-in arguments?  Only
> outputting the method name, you can still tell what needs to be
> implemented.  Also, to output each argument, there are typedefs to
> consider, and you have to choose whether to dereference any pointer
> arguments, which makes it rather difficult to automate the process.
> 

It's nice if you can put in the effort, but for just stubbing
interfaces I think you can get away with FIXME("%p\n", This). Actual
function implementations should trace the arguments correctly.

Andrew



[prev in list] [next in list] [prev in thread] [next in thread]