[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/2] regedit: Handle comment lines with leading spaces and tabs
From:       Hugh McMaster <hugh.mcmaster () outlook ! com>
Date:       2017-03-31 12:31:37
Message-ID: MEXPR01MB0807AEB02AC3754BC20570A3F2370 () MEXPR01MB0807 ! ausprd01 ! prod ! outlook ! com
[Download RAW message or body]

On Friday, 31 March 2017 11:07 PM, Alexandre Julliard wrote:
> You can also ignore white space before comments, but still return it for
> other lines, if there is a case where the callers would want that.
> Otherwise getting rid of whitespace right away is fine. A few test cases
> with leading whitespace may be a good idea.

Somewhat strangely, we actually call isspaceW() in processSetValue() before we
get the registry value name. But it is already too late. We need to check for
whitespace in processRegEntry() or earlier; otherwise, the import fails.

So I think handling whitespace in get_lineA/W() will be far more efficient
and easier to maintain. But to be certain, I'll add some tests with whitespace
variations first.

Thanks for the advice.

--
Hugh McMaster


[prev in list] [next in list] [prev in thread] [next in thread]