[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 5/5] user32: Store the item rects as relative to the items_rect.
From:       Huw Davies <huw () codeweavers ! com>
Date:       2017-03-29 9:52:06
Message-ID: 20170329095206.GA7514 () merlot ! physics ! ox ! ac ! uk
[Download RAW message or body]

On Tue, Mar 28, 2017 at 10:16:46PM +0200, Alexandre Julliard wrote:
> Huw Davies <huw@codeweavers.com> writes:
> 
> > Signed-off-by: Huw Davies <huw@codeweavers.com>
> > ---
> > dlls/user32/menu.c | 68 ++++++++++++++++++++++++++----------------------------
> > 1 file changed, 33 insertions(+), 35 deletions(-)
> 
> This fails here:
> 
> ../../../tools/runtest -q -P wine -T ../../.. -M user32.dll -p user32_test.exe.so \
> win && touch win.ok win.c:1104: Test failed: window rect does not match: \
> style:exstyle=0x94000000:0x00000000, menu=1, win=(110,100)-(335,300), \
> calc=(110,99)-(335,300)

Sorry about that.  That'll teach me to:
i.  Run the entire set of tests.
ii. Not to remove mysterious '+1's without more testing (see i.).

Huw.


[prev in list] [next in list] [prev in thread] [next in thread]