[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 4/9] xmllite: Return static namespace instances for default namespaces in reader_lookup_n
From:       Jacek Caban <jacek () codeweavers ! com>
Date:       2017-03-28 15:26:01
Message-ID: 21522aa9-1384-7ccd-c60d-f1b65615222f () codeweavers ! com
[Download RAW message or body]

On 28.03.2017 16:54, Nikolay Sivov wrote:
> On 28.03.2017 17:44, Jacek Caban wrote:
>> Signed-off-by: Jacek Caban <jacek@codeweavers.com>
>> ---
>>  dlls/xmllite/reader.c | 33 +++++++++++++++++++++++++++------
>>  1 file changed, 27 insertions(+), 6 deletions(-)
>>
>
>> +static struct ns default_ns = {
>> +    { emptyW },
>> +    { emptyW }
>>  };
>>  
> I think this could use a better name. Default namespace is something
> defined with unprefixed "xmlns" attribute name. Maybe empty_ns? To match
> empty strings naming.

Sure, I will rename it.

> Also everything static in this patch should be also const, no?


Some of them, with additional changes, yes. I will send a new patch set.
Strings themselves can't be const for the same reason they are not const
in strval static variables.


Thanks,

Jacek




[prev in list] [next in list] [prev in thread] [next in thread]