[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 2/2 v2] devenum: Implement IMoniker::IsEqual().
From:       Jactry Zeng <jactry92 () gmail ! com>
Date:       2017-03-27 15:42:47
Message-ID: CAManwExkdCpVmwd260y+d9hAW0grv2PTFPTuQzbCigDV-U+biA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Thanks again!

2017-03-27 23:08 GMT+08:00 Andrew Eikum <aeikum@codeweavers.com>:

> Thanks, just a couple more tweaks.
>
> On Mon, Mar 27, 2017 at 10:57:36PM +0800, Jactry Zeng wrote:
> > diff --git a/dlls/devenum/tests/devenum.c b/dlls/devenum/tests/devenum.c
> > index e3c0f47256..b6275be8d2 100644
> > --- a/dlls/devenum/tests/devenum.c
> > +++ b/dlls/devenum/tests/devenum.c
> > @@ -135,6 +135,94 @@ static void test_devenum(IBindCtx *bind_ctx)
> >      if(sizeof(void*) == 4)
> >          ok(have_mrle, "mrle codec not found\n");
> >  }
> > +static void test_moniker_isequal(void)
> > +{
> > +    HRESULT res;
> > +    ICreateDevEnum *create_devenum = NULL;
> > +    IEnumMoniker *enum_moniker0 = NULL, *enum_moniker1 = NULL;
> > +    IMoniker *moniker0 = NULL, *moniker1 = NULL;
> > +
> > +    res = CoCreateInstance(&CLSID_SystemDeviceEnum, NULL,
> CLSCTX_INPROC,
> > +                           &IID_ICreateDevEnum,
> (LPVOID*)&create_devenum);
> > +    if (res)
>
> Please use FAILED() here.
>
> > +         if (SUCCEEDED(IEnumMoniker_Next(enum_moniker0, 1, &moniker0,
> NULL)) &&
> > +             SUCCEEDED(IEnumMoniker_Next(enum_moniker1, 1, &moniker1,
> NULL)))
> > +        {
> > +            res = IMoniker_IsEqual(moniker0, moniker1);
> > +            ok(SUCCEEDED(res), "IMoniker_IsEqual failed (res = %x)\n",
> res);
> > +
> > +            res = IMoniker_IsEqual(moniker1, moniker0);
> > +            ok(SUCCEEDED(res), "IMoniker_IsEqual failed (res = %x)\n",
> res);
>
> These should be compared against S_OK, otherwise S_FALSE will also
> pass the test.
>
> Andrew
>
>
>


-- 
Regards,
Jactry Zeng

[Attachment #5 (text/html)]

<div dir="ltr">Thanks again!</div><div class="gmail_extra"><br><div \
class="gmail_quote">2017-03-27 23:08 GMT+08:00 Andrew Eikum <span dir="ltr">&lt;<a \
href="mailto:aeikum@codeweavers.com" \
target="_blank">aeikum@codeweavers.com</a>&gt;</span>:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Thanks, just a couple more tweaks.<br> <br>
On Mon, Mar 27, 2017 at 10:57:36PM +0800, Jactry Zeng wrote:<br>
&gt; diff --git a/dlls/devenum/tests/devenum.c b/dlls/devenum/tests/devenum.c<br>
&gt; index e3c0f47256..b6275be8d2 100644<br>
&gt; --- a/dlls/devenum/tests/devenum.c<br>
&gt; +++ b/dlls/devenum/tests/devenum.c<br>
&gt; @@ -135,6 +135,94 @@ static void test_devenum(IBindCtx *bind_ctx)<br>
&gt;         if(sizeof(void*) == 4)<br>
&gt;               ok(have_mrle, &quot;mrle codec not found\n&quot;);<br>
&gt;   }<br>
&gt; +static void test_moniker_isequal(void)<br>
&gt; +{<br>
&gt; +      HRESULT res;<br>
&gt; +      ICreateDevEnum *create_devenum = NULL;<br>
&gt; +      IEnumMoniker *enum_moniker0 = NULL, *enum_moniker1 = NULL;<br>
&gt; +      IMoniker *moniker0 = NULL, *moniker1 = NULL;<br>
&gt; +<br>
&gt; +      res = CoCreateInstance(&amp;CLSID_<wbr>SystemDeviceEnum, NULL, \
CLSCTX_INPROC,<br> &gt; +                                         \
&amp;IID_ICreateDevEnum, (LPVOID*)&amp;create_devenum);<br> &gt; +      if (res)<br>
<br>
Please use FAILED() here.<br>
<br>
&gt; +              if (SUCCEEDED(IEnumMoniker_Next(<wbr>enum_moniker0, 1, \
&amp;moniker0, NULL)) &amp;&amp;<br> &gt; +                    \
SUCCEEDED(IEnumMoniker_Next(<wbr>enum_moniker1, 1, &amp;moniker1, NULL)))<br> &gt; +  \
{<br> &gt; +                  res = IMoniker_IsEqual(moniker0, moniker1);<br>
&gt; +                  ok(SUCCEEDED(res), &quot;IMoniker_IsEqual failed (res = \
%x)\n&quot;, res);<br> &gt; +<br>
&gt; +                  res = IMoniker_IsEqual(moniker1, moniker0);<br>
&gt; +                  ok(SUCCEEDED(res), &quot;IMoniker_IsEqual failed (res = \
%x)\n&quot;, res);<br> <br>
These should be compared against S_OK, otherwise S_FALSE will also<br>
pass the test.<br>
<span class="HOEnZb"><font color="#888888"><br>
Andrew<br>
<br>
<br>
</font></span></blockquote></div><br><br clear="all"><div><br></div>-- <br><div \
class="gmail_signature" data-smartmail="gmail_signature"><div \
dir="ltr"><div>Regards,<br></div><div>Jactry Zeng</div><div><br></div></div></div> \
</div>


[Attachment #6 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread]