[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/5] wined3d: Use the command stream state in wined3d_cs_exec_draw().
From:       Sebastian Lackner <sebastian () fds-team ! de>
Date:       2017-02-28 14:24:26
Message-ID: 4b547b29-989b-690a-7ae3-fb9f6a15b6d5 () fds-team ! de
[Download RAW message or body]

On 28.02.2017 15:06, Henri Verbeet wrote:
> On 28 February 2017 at 14:52, Sebastian Lackner <sebastian@fds-team.de> wrote:
>> This patch causes corrupted graphics in multiple games. The problem is
>> caused by uninitialized memory in the wined3d_state structs. Currently
>> the struct is only cleared in wined3d_cs_exec_reset_state, but it
>> probably should be cleared always when WINED3D_STATE_INIT_DEFAULT is
>> passed, otherwise the CS and the main state can go out of sync. Could
>> you please take a look?
>>
> It does look like we forget to clear the state structure in
> wined3d_device_reset(). Is fixing that not enough?
> 

Yes, it seems to be sufficient (at least for all games I am aware of).
I have sent the patch used for testing to the ML.

Best regards,
Sebastian




[prev in list] [next in list] [prev in thread] [next in thread]