[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: wine/test.h: Identify test result lines printed by child processes.
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2017-01-31 18:11:38
Message-ID: 871svjje05.fsf () winehq ! org
[Download RAW message or body]

Francois Gouget <fgouget@codeweavers.com> writes:

> On Mon, 30 Jan 2017, Alexandre Julliard wrote:
> [...]
> > I don't think the test framework should be modifying the environment in
> > all the tests. It already breaks some things:
> > 
> > ../../../tools/runtest -q -P wine -T ../../.. -M msvcrt.dll -p msvcrt_test.exe.so \
> > environ && touch environ.ok environ.c:198: Test failed: Expected environment \
> >                 block pointer element to be non-NULL
> > wine: Unhandled page fault on read access to 0x00000000 at address 0x7ed2a986 \
> > (thread 0074), starting debugger...
> 
> Damn.
> 
> I still think making the child process result lines different from 
> their parent's is necessary to fix bug 32354 but I'm open to 
> alternatives if someone has any idea.
> https://bugs.winehq.org/show_bug.cgi?id=32354

Couldn't you simply print the pid, have winetest print it too on the
'done' line, and check that they match?

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]