[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] wined3d: Recognize SM5 dcl_resource_raw instruction.
From:       guillaume.charifi () sfr ! fr
Date:       2017-01-29 12:28:15
Message-ID: 1893225351.80830.1485692895802.JavaMail.www () wsfrf1421
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Yes, you're right, I forgot to commit the declaration of raw_resource in \
wined3d_private.<br> And yes, it can be replaced by dst instead.
<div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">
<div class="gl_quoted">On Sun, Jan 29, 2017 at 11:52 AM, Guillaume Charifi<br>
wrote:<br>
&gt; Signed-off-by: Guillaume Charifi<br>
&gt; ---<br>
&gt; dlls/wined3d/arb_program_shader.c | 1 +<br>
&gt; dlls/wined3d/glsl_shader.c | 1 +<br>
&gt; dlls/wined3d/shader.c | 6 ++++++<br>
&gt; dlls/wined3d/shader_sm4.c | 10 ++++++++++<br>
&gt; dlls/wined3d/wined3d_private.h | 1 +<br>
&gt; 5 files changed, 19 insertions(+)<br>
<br>
This patch doesn't even compile. Please test your patches before<br>
sending them to wine-patches.<br>
<br>
&gt; +static void shader_sm5_read_dcl_resource_raw(struct wined3d_shader_instruction \
*ins,<br> &gt; + DWORD opcode, DWORD opcode_token, const DWORD *tokens, unsigned int \
token_count,<br> &gt; + struct wined3d_sm4_data *priv)<br>
&gt; +{<br>
&gt; + shader_sm4_read_dst_param(priv, &amp;tokens, WINED3D_DATA_RESOURCE, \
&amp;ins-&gt;declaration.raw_resource.reg);<br> &gt; +}<br>
<br>
You should just use "ins-&gt;declaration.dst".</div>
</div>


[Attachment #5 (text/html)]

Yes, you're right, I forgot to commit the declaration of raw_resource in \
wined3d_private.<br> And yes, it can be replaced by dst instead.
<div class="gl_quote" style="margin-top: 20px; padding-top: 5px;">
<div class="gl_quoted">On Sun, Jan 29, 2017 at 11:52 AM, Guillaume Charifi<br>
wrote:<br>
&gt; Signed-off-by: Guillaume Charifi<br>
&gt; ---<br>
&gt; dlls/wined3d/arb_program_shader.c | 1 +<br>
&gt; dlls/wined3d/glsl_shader.c | 1 +<br>
&gt; dlls/wined3d/shader.c | 6 ++++++<br>
&gt; dlls/wined3d/shader_sm4.c | 10 ++++++++++<br>
&gt; dlls/wined3d/wined3d_private.h | 1 +<br>
&gt; 5 files changed, 19 insertions(+)<br>
<br>
This patch doesn't even compile. Please test your patches before<br>
sending them to wine-patches.<br>
<br>
&gt; +static void shader_sm5_read_dcl_resource_raw(struct wined3d_shader_instruction \
*ins,<br> &gt; + DWORD opcode, DWORD opcode_token, const DWORD *tokens, unsigned int \
token_count,<br> &gt; + struct wined3d_sm4_data *priv)<br>
&gt; +{<br>
&gt; + shader_sm4_read_dst_param(priv, &amp;tokens, WINED3D_DATA_RESOURCE, \
&amp;ins-&gt;declaration.raw_resource.reg);<br> &gt; +}<br>
<br>
You should just use "ins-&gt;declaration.dst".</div>
</div>


[Attachment #6 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread]