[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] ws2_32/tests: Add IDN resolution test for GetAddrInfoW
From:       Bruno Jesus <00cpxxx () gmail ! com>
Date:       2016-11-29 14:58:29
Message-ID: CALF_nUS_GOzCftJJxfxOnxrjV_QF7kdWPjYX8Oxmr32XDRaf-w () mail ! gmail ! com
[Download RAW message or body]

On Tue, Nov 29, 2016 at 12:10 PM, Alexandre Julliard
<julliard@winehq.org> wrote:
> Bruno Jesus <00cpxxx@gmail.com> writes:
>
>> I'm using €.linux.it because I could not find any standard domain name
>> for validation. Maybe winehq.org could have a IDN sub-domain name to
>> test.
>
> I created テスト.winehq.org for this purpose.

Thanks, I have updated the tests but testbot VMs are not resolving it
yet, so I didn't send the patch yet.

>> Also instead of broken'ing every test to catch Windows <= 7 I'm
>> skipping before, so real failures are not lost due to broken covering
>> them in Win >= 8.
>
> I still think it's better to avoid version checks. You can do broken()
> on the first test and skip the others if you detect the Win 7 behavior.

Ok, no problem.

Best wishes,
Bruno



[prev in list] [next in list] [prev in thread] [next in thread]