[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: comctl32/tests: Avoid using memset() on RECTs.
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2016-07-30 20:23:05
Message-ID: f443d32e-32b3-6744-96fd-a072fd1d0596 () gmail ! com
[Download RAW message or body]

On 30.07.2016 23:18, Michael Stefaniuc wrote:
> On 07/30/2016 09:58 PM, Nikolay Sivov wrote:
>> On 30.07.2016 22:55, Michael Stefaniuc wrote:
>>> -    memset(&r1, 0, sizeof r1);
>>> -    r1.left = LVIR_ICON;
>>> +    SetRect(&r1, LVIR_ICON, 0, 0, 0);
>>
>> I don't like this, I think it's better to use SetRect() when actual
>> coordinates are used, and LVIR_* has special meaning.
> Uhm? I have added 36 of those with commit 87bc2aa6 and you signed of on
> that.
> 

Ok, no reason to stop now then.

> For me those are still RECTs even though MS uses them for other stuff.
> 
> bye
> 	michael
> 
> 




[prev in list] [next in list] [prev in thread] [next in thread]