[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/4] mpr: Implement local name automatic redirection for disks.
From:       Pierre Schweitzer <pierre () reactos ! org>
Date:       2016-07-29 16:31:19
Message-ID: 49241e05-b946-9419-6fc4-18147f275fe4 () reactos ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Is there anything left to fix?

Le 28/07/2016 à 10:44, Pierre Schweitzer a écrit :
> I also modified 2nd patch of the patch, because it was suffering the
> same issue and wasn't applying any longer.
> Both have been resent.
> 
> Le 28/07/2016 à 10:12, Alexandre Julliard a écrit :
>> Pierre Schweitzer <pierre@reactos.org> writes:
>>
>>> Hi,
>>>
>>> I wanted to avoid yet another recopy (in the ANSI case) especially since
>>> input is well-known: user necessarily provided NULL ptr to reach that point.
>>> But, if you prefer, I can do another copy. But in the ANSI case, it will
>>> mean that NETRESOURCE structure has been copied twice (rather expensive).
>>
>> It's not expensive, it's a small structure, and you don't need to
>> duplicate the pointers.
>>
> 
> 
> 
> 
> 


-- 
Pierre Schweitzer <pierre at reactos.org>
System & Network Administrator
Senior Kernel Developer
ReactOS Deutschland e.V.


["smime.p7s" (application/pkcs7-signature)]
[Attachment #6 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread]