[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 7/7] d3drm: Implement IDirect3DRM*::CreateViewport.
From:       Aaryaman Vasishta <jem456.vasishta () gmail ! com>
Date:       2016-06-27 7:36:38
Message-ID: CABVHfRu7bW1BPxo4GD9LGkvYOE5a9JaDGF2yKbKWpjGCLw-_vg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Monday, June 27, 2016, Stefan Dösinger <stefandoesinger@gmail.com> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta:
> > +    hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left,
> rc.top, rc.right, rc.bottom + 1, &viewport2);
> > +    ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE, got
> %#x.\n", hr);
> > +    if (FAILED(hr))
> > +    {
> > +        hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3,
> rc.left, rc.top, rc.right, rc.bottom, NULL);
> > +        ok(hr == D3DRMERR_BADVALUE, "Expected hr == D3DRMERR_BADVALUE,
> got %#x.\n", hr);
> > +    }
> Afaics the if (FAILED(hr)) isn't necessary here.
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJXcFm2AAoJEN0/YqbEcdMwbewP/11c9oFcbQjek33cW30miUka
> fO/BIk3qk6xpsz/CMF/DRmwQvqPObSnG5zsAXn4j1hsJM2y3EBRjLeZx1/CqyR9s
> uQ9JyN85zB2rEDkSpLFNaOIW0hnX7bFFnOmZlIlZPYRH1cqQSJcg5gcAq8EnLeIl
> ioWW0qK3ZREeRDZXEe0YxuwGqWE+HouUNzS/En9OrlZ9b76zfuRcH2rrGSw+2BPo
> Az8PzllV8v3Df/HxqYyeG9JxgjWElk2aQGfHP5BPUE/JF5+Ky2xEb6RvHVGJQ64P
> G/HKJGlKZT/VgQGCbJx6s5bNazBiJSyD4a6dj5IbEbWmnySJIbwW2DNXrcxKT9MO
> oz0NNyjMQAVkJx45QVvtxm+5QsJIbO6V/38h+zsPW0F6dGrYoqBXXSFbsbp4ge2G
> S2EC+bJVHsUwc2en52BaqJCRDYLSgxNaD2kL8ovZjLYBVi3jlfTP/OcIXYjam2I7
> 67b8VEeV7xBILU2uvhFxwpwLIgtVJ1b2QUyH3TjrKfClGu5lbe/VbASsrDjBaJV1
> ZZMqcmn1JU/P24wQVWb2gfqN12ktvhEnnYznwz8zw7OKdpOUoKlOXr/06tlrMmei
> YfuGMZmJyxMJQSsfIVtoFH1HmqlZuk5QUjnjyShYDDf4TlKWZAtn4o4JJbt4n1J0
> bOobnKLPsEGKSNhoZbnm
> =xbZw
> -----END PGP SIGNATURE-----
>
Right, they're not needed now that this method is implemented.


Cheers,
Aaryaman

[Attachment #5 (text/html)]

<br><br>On Monday, June 27, 2016, Stefan Dösinger &lt;<a \
href="mailto:stefandoesinger@gmail.com">stefandoesinger@gmail.com</a>&gt; \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
                #ccc solid;padding-left:1ex">-----BEGIN PGP SIGNED MESSAGE-----<br>
Hash: SHA256<br>
<br>
Am 2016-06-24 um 22:49 schrieb Aaryaman Vasishta:<br>
&gt; +      hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left, \
rc.top, rc.right, rc.bottom + 1, &amp;viewport2);<br> &gt; +      ok(hr == \
D3DRMERR_BADVALUE, &quot;Expected hr == D3DRMERR_BADVALUE, got %#x.\n&quot;, hr);<br> \
&gt; +      if (FAILED(hr))<br> &gt; +      {<br>
&gt; +            hr = IDirect3DRM3_CreateViewport(d3drm3, device3, frame3, rc.left, \
rc.top, rc.right, rc.bottom, NULL);<br> &gt; +            ok(hr == D3DRMERR_BADVALUE, \
&quot;Expected hr == D3DRMERR_BADVALUE, got %#x.\n&quot;, hr);<br> &gt; +      }<br>
Afaics the if (FAILED(hr)) isn&#39;t necessary here.<br>
<br>
-----BEGIN PGP SIGNATURE-----<br>
Version: GnuPG v2<br>
<br>
iQIcBAEBCAAGBQJXcFm2AAoJEN0/YqbEcdMwbewP/11c9oFcbQjek33cW30miUka<br>
fO/BIk3qk6xpsz/CMF/DRmwQvqPObSnG5zsAXn4j1hsJM2y3EBRjLeZx1/CqyR9s<br>
uQ9JyN85zB2rEDkSpLFNaOIW0hnX7bFFnOmZlIlZPYRH1cqQSJcg5gcAq8EnLeIl<br>
ioWW0qK3ZREeRDZXEe0YxuwGqWE+HouUNzS/En9OrlZ9b76zfuRcH2rrGSw+2BPo<br>
Az8PzllV8v3Df/HxqYyeG9JxgjWElk2aQGfHP5BPUE/JF5+Ky2xEb6RvHVGJQ64P<br>
G/HKJGlKZT/VgQGCbJx6s5bNazBiJSyD4a6dj5IbEbWmnySJIbwW2DNXrcxKT9MO<br>
oz0NNyjMQAVkJx45QVvtxm+5QsJIbO6V/38h+zsPW0F6dGrYoqBXXSFbsbp4ge2G<br>
S2EC+bJVHsUwc2en52BaqJCRDYLSgxNaD2kL8ovZjLYBVi3jlfTP/OcIXYjam2I7<br>
67b8VEeV7xBILU2uvhFxwpwLIgtVJ1b2QUyH3TjrKfClGu5lbe/VbASsrDjBaJV1<br>
ZZMqcmn1JU/P24wQVWb2gfqN12ktvhEnnYznwz8zw7OKdpOUoKlOXr/06tlrMmei<br>
YfuGMZmJyxMJQSsfIVtoFH1HmqlZuk5QUjnjyShYDDf4TlKWZAtn4o4JJbt4n1J0<br>
bOobnKLPsEGKSNhoZbnm<br>
=xbZw<br>
-----END PGP SIGNATURE-----<br>
</blockquote><div>Right, they&#39;re not needed now that this method is \
implemented.</div><div><br></div><div><br></div><div>Cheers,</div><div>Aaryaman  \
</div>


[Attachment #6 (text/plain)]




[prev in list] [next in list] [prev in thread] [next in thread]