[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/3] comdlg32: Optimize FILEDLG95_FILENAME_FillFromSelection.
From:       Lauri_Kenttä <lauri.kentta () gmail ! com>
Date:       2016-06-25 10:56:12
Message-ID: e7de0257cf22233055ae73fcbaec1cfe () k-piste ! dy ! fi
[Download RAW message or body]

On 2016-06-23 16:44, Henri Verbeet wrote:
> On 23 June 2016 at 13:29, Lauri Kenttä <lauri.kentta@gmail.com> wrote:
>> This trades some memory for speed, but since currently selecting
>> 1000 files takes over a minute but the required memory for those
>> 1000 filenames is only 262 kB (worst case), this seems a reasonable
>> trade-off.
>> 
> That's probably fine, but is there any reason this can't use the
> standard approach of just doubling the buffer size when you run out of
> space?

No reason. I'll fix that.

> If this is performance critical code, the multiple copies of the
> string related to GetName() probably don't help either.

I'll fix that too, although it doesn't make much of a difference.

Thanks,

-- 
Lauri Kenttä



[prev in list] [next in list] [prev in thread] [next in thread]