[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: imm32, user32: Create and destroy the default IME window implicitly. (try 3)
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2016-05-30 2:52:53
Message-ID: 87y46sl0je.fsf () winehq ! org
[Download RAW message or body]

Akihiro Sagawa <sagawa.aki@gmail.com> writes:

> On Fri, 27 May 2016 12:39:27 +0900, Alexandre Julliard wrote:
>> Do you have a test showing that this is supposed to happen between
>> WM_NCCREATE and WM_NCCALCSIZE?  If not, I think it would be useful to
>> add one.
> Yes. I wrote a patch [1/5] showing that the IME window is created
> between WM_NCCREATE and WM_NCCALCSIZE.

Thanks!

>> Also since the window class is in user32 now the window
>> creation could probably happen there too.
> Regarding window creation, I think imm32 is better. Because imm32 has
> ImmDisableIME API. It affects IME window creation as seen in patch [5/5].
> If I implement the API, its settings will be stored in IMMThreadData,
> and it will be referred on window creation. So, creating the IME window
> in imm32 makes sense.

OK, in that case I'd say the other checks (system metrics, class name,
refcount) should all be in imm32 too.

-- 
Alexandre Julliard
julliard@winehq.org



[prev in list] [next in list] [prev in thread] [next in thread]