[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] comctl32: Use SetRect() instead of open coding it.
From:       Nikolay Sivov <nsivov () codeweavers ! com>
Date:       2016-05-28 13:45:02
Message-ID: 5749A0DE.80309 () codeweavers ! com
[Download RAW message or body]

      if (dis->itemAction & ODA_FOCUS) {
-	rect.left = xbase + xioff - 1;
-	rect.right = rect.left + txtsize.cx + 2;
-	rect.top = dis->rcItem.top;
-	rect.bottom = dis->rcItem.bottom;
+	SetRect(&rect, xbase + xioff - 1, dis->rcItem.top, rect.left + txtsize.cx + 2, dis->rcItem.bottom);
  	DrawFocusRect(dis->hDC, &rect);
      }

This change is obviously wrong. I think it's better to leave this one as is.




[prev in list] [next in list] [prev in thread] [next in thread]