[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: server: Fix detection of duplicate console history lines. (v2)
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2016-04-28 12:24:41
Message-ID: 87twilncom.fsf () winehq ! org
[Download RAW message or body]

Sebastian Lackner <sebastian@fds-team.de> writes:

> Signed-off-by: Sebastian Lackner <sebastian@fds-team.de>
> ---
> Changes in v2:
> * We can't really use memcmp because it could allow exploits with special input,
>   like "abc\0def", where it would probably compare past the end of the string.

Note that you don't need special input, any comparison with a shorter
string can potentially overrun.

-- 
Alexandre Julliard
julliard@winehq.org



[prev in list] [next in list] [prev in thread] [next in thread]