[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [v2 PATCH] d3dx10: Implement D3DX10UnsetAllDeviceObjects()
From:       Józef Kucia <joseph.kucia () gmail ! com>
Date:       2016-04-27 19:37:31
Message-ID: CAKF0LCWPauYw1nm=x7EGDJLe_FSUjuh+aN6U=AnzsomyfS63ag () mail ! gmail ! com
[Download RAW message or body]

On Wed, Apr 27, 2016 at 1:40 PM, Nikolay Sivov <nsivov@codeweavers.com> wrote:
> +    /* Verify the initial state after device creation. */

I think it's unnecessary to duplicate tests for the device initial
state in d3dx10 tests.

> +    /* Verify the behavior of set state methods. */

This part is a test for ID3D10Device_OMSetBlendState(). It isn't
necessary as well.

> +    /* Verify the set state. */

This part isn't strictly necessary but it can be argued that it makes
sense to verify that the state was properly set before calling
D3DX10UnsetAllDeviceObjects().



[prev in list] [next in list] [prev in thread] [next in thread]