[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [v2 PATCH 1/3] gdiplus: Implement GdipGetPenTransform
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2016-01-31 10:04:36
Message-ID: CAG4Z_JJLuFx1mP2yUOit8n3xMA8fmFX6e1QZUt7TdSryFDA=Ag () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Sunday, 31 January 2016, Alistair Leslie-Hughes <
leslie_alistair@hotmail.com> wrote:

> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com
> <javascript:;>>
> ---
>  dlls/gdiplus/gdiplus_private.h | 1 +
>  dlls/gdiplus/pen.c             | 9 ++++-----
>  dlls/gdiplus/tests/pen.c       | 6 +++---
>  3 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/dlls/gdiplus/gdiplus_private.h
> b/dlls/gdiplus/gdiplus_private.h
> index 1af0bd0..fd45a49 100644
> --- a/dlls/gdiplus/gdiplus_private.h
> +++ b/dlls/gdiplus/gdiplus_private.h
> @@ -197,6 +197,7 @@ struct GpPen{
>      REAL offset;    /* dash offset */
>      GpBrush *brush;
>      GpPenAlignment align;
> +    GpMatrix *transform;
>  };


Why does it have to be a separate allocation? It looks like GpMatrix field
will work fine.

[Attachment #5 (text/html)]

<br><br>On Sunday, 31 January 2016, Alistair Leslie-Hughes &lt;<a \
href="mailto:leslie_alistair@hotmail.com">leslie_alistair@hotmail.com</a>&gt; \
wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px \
#ccc solid;padding-left:1ex">Signed-off-by: Alistair Leslie-Hughes &lt;<a \
href="javascript:;" onclick="_e(event, &#39;cvml&#39;, \
                &#39;leslie_alistair@hotmail.com&#39;)">leslie_alistair@hotmail.com</a>&gt;<br>
                
---<br>
  dlls/gdiplus/gdiplus_private.h | 1 +<br>
  dlls/gdiplus/pen.c                    | 9 ++++-----<br>
  dlls/gdiplus/tests/pen.c           | 6 +++---<br>
  3 files changed, 8 insertions(+), 8 deletions(-)<br>
<br>
diff --git a/dlls/gdiplus/gdiplus_private.h b/dlls/gdiplus/gdiplus_private.h<br>
index 1af0bd0..fd45a49 100644<br>
--- a/dlls/gdiplus/gdiplus_private.h<br>
+++ b/dlls/gdiplus/gdiplus_private.h<br>
@@ -197,6 +197,7 @@ struct GpPen{<br>
        REAL offset;      /* dash offset */<br>
        GpBrush *brush;<br>
        GpPenAlignment align;<br>
+      GpMatrix *transform;<br>
  };</blockquote><div><br></div><div>Why does it have to be a separate allocation? It \
looks like GpMatrix field will work fine.  <span></span></div>





[prev in list] [next in list] [prev in thread] [next in thread]