[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: mshtml: Add IHTMLXMLHttpRequest::responseXML() method implementation. (try 2)
From:       Christopher Harrington <ironiridis+winehq () gmail ! com>
Date:       2015-11-30 23:07:43
Message-ID: CACZk-UHM0N_LaFpOdjW1spCqyUjbzrJ3R9C_zCYfOVFn5RDRVA () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Mon, Nov 30, 2015 at 5:32 AM Jacek Caban <jacek@codeweavers.com> wrote:

> Hi Zhenbo,
>
>
> On 11/27/15 15:49, Zhenbo Li wrote:
>
> 2015-11-14 17:33 GMT+08:00 Zhenbo Li <litimetal@gmail.com> <litimetal@gmail.com>:
>
> +    hres = IXMLDOMDocument_loadXML(xmldoc, str, &vbool);
> +    SysFreeString(str);
> +    if(hres != S_OK || vbool != VARIANT_TRUE) {
> +        ERR("loadXML failed: %08x, returning an cmpty xmldoc\n", hres);
> +    }
>
>
> ERR is not appropriate here. Please use WARN instead.
>

Also "cmpty" possibly a typo for "empty"?


> Thanks,
> Jacek
>
>

[Attachment #5 (text/html)]

<div dir="ltr"><div class="gmail_quote"><div dir="ltr">On Mon, Nov 30, 2015 at 5:32 \
AM Jacek Caban &lt;<a \
href="mailto:jacek@codeweavers.com">jacek@codeweavers.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">  
    
  
  <div text="#000000" bgcolor="#FFFFFF">
    <div>Hi Zhenbo,</div></div><div text="#000000" bgcolor="#FFFFFF"><div><br>
      <br>
      On 11/27/15 15:49, Zhenbo Li wrote:<br>
    </div></div><div text="#000000" bgcolor="#FFFFFF">
    <blockquote type="cite">
      <div style="font-family:-moz-fixed;font-size:12px" lang="x-unicode">
        <pre>2015-11-14 17:33 GMT+08:00 Zhenbo Li <a \
href="mailto:litimetal@gmail.com" \
target="_blank">&lt;litimetal@gmail.com&gt;</a>:</pre></div></blockquote></div><div \
text="#000000" bgcolor="#FFFFFF"><blockquote type="cite"><pre>+    hres = \
IXMLDOMDocument_loadXML(xmldoc, str, &amp;vbool); +    SysFreeString(str);
+    if(hres != S_OK || vbool != VARIANT_TRUE) {
+        ERR(&quot;loadXML failed: %08x, returning an cmpty xmldoc\n&quot;, hres);
+    }</pre>
    </blockquote>
    <br>
    ERR is not appropriate here. Please use WARN \
instead.<br></div></blockquote><div><br></div><div>Also &quot;cmpty&quot; possibly a \
typo for &quot;empty&quot;?</div><div><br></div><blockquote class="gmail_quote" \
style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div \
text="#000000" bgcolor="#FFFFFF"><br>  Thanks,<br>
    Jacek<br>
  </div>

<br>
</blockquote></div></div>





[prev in list] [next in list] [prev in thread] [next in thread]