[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 01/4] msvcp110: Add tr2_sys__Open_dir implementation.(try 4)
From:       YongHao Hu <christopherwuy () gmail ! com>
Date:       2015-10-31 9:35:53
Message-ID: 56348B79.5000004 () gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hi.
On 15/10/30 下午11:08, Piotr Caban wrote:
> On 10/29/15 16:28, YongHao Hu wrote:
>> +    char temppath[MAX_PATH+1];
>> +    TRACE("(%p %s %p %p)\n", target, debugstr_a(dest), err_code, type);
>> +    if(strlen(dest) >= MAX_PATH) {
>> +        *err_code = ERROR_BAD_PATHNAME;
>> +        return NULL;
>> +    }
>> +    strcpy(temppath, dest);
>> +    strcat(temppath, "\\*");
> There may still write outside of temppath array in this code.

I had sent a new patch to upstream.
I think it will fix possible buffer overflow this time.
Thank you very much.

[Attachment #5 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Hi.<br>
    <div class="moz-cite-prefix">On 15/10/30 下午11:08, Piotr Caban wrote:<br>
    </div>
    <blockquote cite="mid:563387D3.9040905@gmail.com" type="cite">On
      10/29/15 16:28, YongHao Hu wrote:
      <br>
      <blockquote type="cite">+    char temppath[MAX_PATH+1];
        <br>
        +    TRACE("(%p %s %p %p)\n", target, debugstr_a(dest),
        err_code, type);
        <br>
        +    if(strlen(dest) &gt;= MAX_PATH) {
        <br>
        +        *err_code = ERROR_BAD_PATHNAME;
        <br>
        +        return NULL;
        <br>
        +    }
        <br>
        +    strcpy(temppath, dest);
        <br>
        +    strcat(temppath, "\\*");
        <br>
      </blockquote>
      There may still write outside of temppath array in this code.
      <br>
    </blockquote>
    <br>
    I had sent a new patch to upstream.<br>
    I think it will fix possible buffer overflow
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
    this time.<br>
    <meta http-equiv="content-type" content="text/html; charset=UTF-8">
    Thank you very much.<br>
  </body>
</html>




[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic