[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] shell32: Stop memory leak (valgrind)
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2015-10-29 9:25:08
Message-ID: 5631E5F4.8020101 () gmail ! com
[Download RAW message or body]

On 29.10.2015 12:21, Alistair Leslie-Hughes wrote:
> Signed-off-by: Alistair Leslie-Hughes <leslie_alistair@hotmail.com>
> ---
>   dlls/shell32/shellitem.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/dlls/shell32/shellitem.c b/dlls/shell32/shellitem.c
> index f64c2d0..799c6c0 100644
> --- a/dlls/shell32/shellitem.c
> +++ b/dlls/shell32/shellitem.c
> @@ -1198,7 +1198,10 @@ HRESULT WINAPI SHCreateShellItemArray(PCIDLIST_ABSOLUTE pidlParent,
>       {
>           ret = create_shellitemarray(array, cidl, ppsiItemArray);
>           if(SUCCEEDED(ret))
> +        {
> +            HeapFree(GetProcessHeap(), 0, array);
>               return ret;
> +        }
>       }
>
>       /* Something failed, clean up. */
>

There is another place with same problem, I just sent a complete fix.


[prev in list] [next in list] [prev in thread] [next in thread]