[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: How to add the Signed-off-by field in the git patch
From:       Michael Stefaniuc <mstefani () redhat ! com>
Date:       2015-09-28 11:12:16
Message-ID: 56092090.9000304 () redhat ! com
[Download RAW message or body]

On 09/28/2015 12:46 PM, Frédéric Delanoy wrote:
> On Tue, Sep 22, 2015 at 5:02 PM, Alex Henrie <alexhenrie24@gmail.com> wrote:
>> I just updated http://wiki.winehq.org/SubmittingPatches with
>> instructions on how to include the Signed-off-by line. I will update
>> the GitWine page soon. Please feel free to improve the wiki further.
>>
>> -Alex
> 
> In the SubmittingPatches page, you say one should sign-off one's own
> patches. Isn't that rather redundant when you are the author?
Not redundant at all. The author signing-off just signals that the patch
is ready for upstream and that the author takes responsibility for it.
Without a sign-off it might be just a hack or a RFC or what not.

> I believe Signed-off is for patch reviewers, not main authors.
It is for both author(s) and reviewers.

bye
	michael



[prev in list] [next in list] [prev in thread] [next in thread]