[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: ws2_32: WSACleanup cleans up open sockets (OSX only)
From:       Matt Durgavich <mattdurgavich () gmail ! com>
Date:       2015-08-29 18:36:29
Message-ID: D583BB73-64DC-41A9-B9FC-A2E93A8ABE18 () gmail ! com
[Download RAW message or body]

Cool. Thanks for all the feedback. I'm happy to be contributing, and I got a crash course in server and dll development.

:)

> On Aug 29, 2015, at 2:19 PM, Bruno Jesus <00cpxxx@gmail.com> wrote:
> 
> On Sun, Aug 30, 2015 at 2:13 AM, Matt Durgavich <mattdurgavich@gmail.com> wrote:
>> All suggestions rolled in. Removing todos in tests will be a separate patch
> 
> You can't do that, because the changes you are making will break the
> tests (tests will fail since problems were fixed and todo_wine need to
> be removed). Just merge the todo removal and IMO the patch is fine.
> Remember to run make test inside the ws2_32/tests folder to check if
> it runs fine.
> 
> It amazes me that such a simple solution could be found for this bug,
> thanks for working on it and thanks Henri for the tip.




[prev in list] [next in list] [prev in thread] [next in thread]