[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: kernel32: K32EnumProcessModules: Handle NULL pointer gracefully.
From:       Alex Henrie <alexhenrie24 () gmail ! com>
Date:       2015-06-30 22:04:00
Message-ID: CAMMLpeSq-nNRGL0hD3Btbt2pQtdrOfsZX9PX7RsiBxiXXdi9xQ () mail ! gmail ! com
[Download RAW message or body]

> diff --git a/dlls/kernel32/module.c b/dlls/kernel32/module.c
> index f495e81..5461881 100644
> --- a/dlls/kernel32/module.c
> +++ b/dlls/kernel32/module.c
> @@ -1226,6 +1226,12 @@ BOOL WINAPI K32EnumProcessModules(HANDLE process, HMODULE *lphModule,
>     if (!init_module_iterator(&iter, process))
>         return FALSE;
>
> +    if (!lphModule)
> +    {
> +        SetLastError(ERROR_NOACCESS);
> +        return FALSE;
> +    }
> +
>     if (!needed)
>     {
>          SetLastError(ERROR_NOACCESS);

Wouldn't it be easier to write "if (!lphModule || !needed)"? Adding a
test or two would also be nice.

-Alex


[prev in list] [next in list] [prev in thread] [next in thread]