[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] msvcp90: Implement time_get<char> ctors and dtors
From:       Piotr Caban <piotr.caban () gmail ! com>
Date:       2015-06-26 16:50:03
Message-ID: 558D82BB.5050301 () gmail ! com
[Download RAW message or body]

On 06/26/15 18:37, Daniel Lehman wrote:
> the string c/dtors need a cast to non-const.  would it be ok to do the cast in the macros at the top?
>
> something like:
> #define locale_string_char_dtor(this)	_Yarn_char_dtor((locale_string *)this)
>
> Then the casts are in one spot and don't need to be sprinkled about
It's useful to be warned about trying to modify const data. It's why I 
don't think it's a good idea to do the cast in the macro. Mangled names 
shows that the casts are also done in native dll. As far as I can see 
there are only 4 functions that needs the casts.



[prev in list] [next in list] [prev in thread] [next in thread]