[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 5/5] wined3d: Always enable GL_PROGRAM_POINT_SIZE in the GLSL backend.
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2015-05-29 7:08:34
Message-ID: CAOsNvwz+YV8a+c4aRESS+F81Zt4tPR04mjnnXX+umqhsMJLYvQ () mail ! gmail ! com
[Download RAW message or body]

On 28 May 2015 at 23:53, Matteo Bruni <matteo.mystral@gmail.com> wrote:
> It's not shared but it should already be executed for each context
> (the flag is stored in struct wined3d_context).
I may have been a bit too quick to write a reply. :)

> It would be surprising to me if that additional flag check has any
> performance impact since it is next to ctx_data->glsl_program which is
> accessed anyway just a bit later.
Yeah, I suppose, although it still seems better to not add unnecessary
code in that path. Something similar applies to struct
vs_compile_args, the two extra BOOLs probably don't hurt too much, but
it seems better to merge them with "clip_enabled" as flags.


[prev in list] [next in list] [prev in thread] [next in thread]