[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] kernel32: Return ERROR_CALL_NOT_IMPLEMENTED in GetUserPreferredUILanguages.
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2015-05-28 4:30:16
Message-ID: 878uc9qq7b.fsf () winehq ! org
[Download RAW message or body]

Mark Harmstone <hellas@burntcomma.com> writes:

> On 27/05/15 14:12, Alexandre Julliard wrote:
>> Not that it really matters, but I don't see why you'd need to change
>> Wine in order to be able to write a test.
>
> How am I supposed to know if GetUserPreferredUILanguages fails because it's not implemented,
> or fails for some other reason?

That doesn't matter. You are testing the Windows behavior, so unless
there's a Windows version that returns ERROR_CALL_NOT_IMPLEMENTED, you
should never need to check for it.

Once your test succeeds on Windows, you add todo_wine in places where
Wine differs. Whether that's because the function is unimplemented, or
because it's implemented but broken, doesn't make any difference as far
as the test is concerned.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]