[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 5/5] wined3d: Don't use the same va_list multiple times in shader_vaddline().
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2015-04-30 8:32:03
Message-ID: CAOsNvwy08vvSidJOd18eYVtJr-h8x9FNqixqHeDRL29OQ0nSfw () mail ! gmail ! com
[Download RAW message or body]

On 29 April 2015 at 23:34, Matteo Bruni <mbruni@codeweavers.com> wrote:
> -static void string_buffer_vsprintf(struct wined3d_string_buffer *buffer, const \
> char *format, va_list args) +static int string_buffer_vsprintf(struct \
> wined3d_string_buffer *buffer, const char *format, va_list args) {
> if (!buffer)
> -        return;
> +        return 0;
> string_buffer_clear(buffer);
> -    shader_vaddline(buffer, format, args);
> +    return shader_vaddline(buffer, format, args);
> }
> 
You could perhaps just merge this into string_buffer_sprintf(), but I
don't care that much.


[prev in list] [next in list] [prev in thread] [next in thread]