[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 1/2] d3d9/tests: Extend the FPU setup test.
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2015-02-27 12:58:06
Message-ID: 87ioenwly9.fsf () winehq ! org
[Download RAW message or body]

Henri Verbeet <hverbeet@gmail.com> writes:

> On 27 February 2015 at 12:43, Stefan Dösinger <stefandoesinger@gmail.com> wrote:
>> Am 2015-02-27 um 12:34 schrieb Henri Verbeet:
>>> Not that I would terribly mind if this got comitted, but I have to
>>> wonder if this really has a lot of value as a regression test?
>> As a regression test not really, except for cases where someone wants
>> to add FPU CW set / restore in the way we're doing it in d3d7. I think
>> the code has value as documentation though.
>>
>> I don't have a strong opinion on this either, but my preference is to
>> have it in the tree rather than in the archives.
>>
> I guess it's mostly a matter of how Alexandre feels about this kind of
> thing then.

I don't mind having them in. At least they don't prevent me from using
the computer while running, unlike some of the other d3d tests ;-)

-- 
Alexandre Julliard
julliard@winehq.org



[prev in list] [next in list] [prev in thread] [next in thread]