[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] [shell32] Implement SHRunControlPanel using ShellExecute
From:       Alex Henrie <alexhenrie24 () gmail ! com>
Date:       2015-02-27 8:50:02
Message-ID: CAMMLpeSLMX__FPP5aW6gwVrk94HiJ=9mKbwFK8augdKSdibW6Q () mail ! gmail ! com
[Download RAW message or body]

+    if((int)ShellExecute(parent,NULL,commandLine,NULL,NULL,SW_NORMAL)>32)
+        return TRUE;
+    else
+        return FALSE;

I think this would be more elegantly expressed as

return (int)ShellExecute(parent,NULL,commandLine,NULL,NULL,SW_NORMAL)>32;

But more importantly, are you sure that SHRunControlPanel will execute
anything? What if the filename doesn't end in .cpl? You'll probably
have to write some tests before this patch is accepted.

-Alex


[prev in list] [next in list] [prev in thread] [next in thread]