[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: makedep: Sanitize the module names before turning them into resource ids.
From:       Alexandre Julliard <julliard () winehq ! org>
Date:       2015-02-24 3:10:41
Message-ID: 87d250rolq.fsf () winehq ! org
[Download RAW message or body]

Francois Gouget <fgouget@free.fr> writes:

> On Fri, 20 Feb 2015, Alexandre Julliard wrote:
> [...]
>> There's no reason that resource ids can't contain dashes,
>
> You're right, it's a bug in wrc.
>
> The simple fix would be to add '-' to the set of allowed characters for 
> tIDENT but in fact the resource and type ids (and probably filenames) 
> can contain pretty much any character. That's much harder to handle in 
> the parser however :-(

Yes, cf. bug 786.

>> and besides, winetest won't know what to do with it if you change the 
>> name.
>
> I did test and that worked... just had to use underscores.

I don't see how winetest can find the dll if it's using underscores.

-- 
Alexandre Julliard
julliard@winehq.org


[prev in list] [next in list] [prev in thread] [next in thread]