[prev in list] [next in list] [prev in thread] [next in thread]
List: wine-devel
Subject: Re: kernel32: Implement Get{Time,Date}FormatEx
From: Nikolay Sivov <bunglehead () gmail ! com>
Date: 2014-12-30 2:12:51
Message-ID: 54A20A23.8010905 () gmail ! com
[Download RAW message or body]
On 30.12.2014 2:06, Sean Burke wrote:
> Provides an implementation of time and date format functions added in
> Vista sufficient to allow some basic applications requiring them to run.
> Includes necessary tests and header defs.
>
>
> Sean Burke
>
>
>
Hi, Sean.
As you can see tests are failing on win2000 and winxp because these
calls are not available on these platforms. You should use
GetProcAddress() to fix that.
> +@ stdcall GetDateFormatEx(ptr long ptr wstr ptr long ptr)
First argument should be 'wstr' as well.
> +@ stdcall GetTimeFormatEx(ptr long ptr wstr ptr long)
Same.
> +INT WINAPI GetDateFormatEx(LPCWSTR lpLocaleName, DWORD dwFlags,
> + const SYSTEMTIME* lpDate, LPCWSTR lpFormat,
> + LPWSTR lpDateStr, INT cchDate, LPCWSTR lpCalendar)
Please use cleaner argument names, like 'localename', 'flags', 'date',
'format', etc. So lowercase, no prefix.
> + lcid = LocaleNameToLCID(lpLocaleName, 0);
> +
> + return NLS_GetDateTimeFormatW(lcid, dwFlags | DATE_DATEVARSONLY, lpDate,
> + lpFormat, lpDateStr, cchDate);
No real need for temporary 'lcid' variable.
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic