[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: gdiplus: fix GdipFillRectangleI no effect on memoryDCwhosewindoworiginpointhas changed
From:       "=?utf-8?B?Q2hhbmdodWkgTGl1?=" <liuchanghui () linuxdeepin ! com>
Date:       2014-12-23 5:31:59
Message-ID: tencent_4107B9FC2C9AF66340A52368 () qq ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

[Attachment #4 (text/plain)]

Dear all:
Thanks for your help. 
I have sent the patch to wine-patches.






------------------
Regards.
 

 
 
 
------------------ Original ------------------
From:  "Vincent Povirk"<madewokherd@gmail.com>;
Date:  Tue, Dec 23, 2014 02:05 AM
To:  "Qian Hong"<fracting@gmail.com>; 
Cc:  "Changhui Liu"<liuchanghui@linuxdeepin.com>; "wine-devel"<wine-devel@winehq.org>; 
Subject:  Re: gdiplus: fix GdipFillRectangleI no effect on memoryDCwhosewindoworiginpointhas changed

 
> It seems the "new patch file" was not sent to public mailing list.
> Changhui, would you mind resend your final patch to wine-patches?

That's odd. Wine-devel was CCed on the mail. Maybe the image
attachment made the email too large, and it was filtered.

They'll have to be sent to wine-patches anyway for proper review.

> Also, Vincent, if you could suggest for a better commit message, that
> would be nice :) You are native English speaker, neither I or Changhui
> is native. But if the commit message looks good to you, then please
> ignore me.

Ah, I sort of skipped over the commit messages, sorry. I would just
remove "no effect" from the third commit message, because there can be
an effect sometimes, it's just wrong. You could also remove the word
"error" from the first two.

The messages don't sound completely natural in English to me, but
there is also limited space, and I can't think of a way to make them
more natural without also making them longer or less descriptive.
[Attachment #5 (text/html)]

<div>Dear all:</div><div>Thanks for your help.&nbsp;</div><div>I have sent the patch \
to wine-patches.</div><div><br></div><div><sign signid="0"><div \
style="color:#909090;font-family:Arial \
Narrow;font-size:12px"><br><br><br><br>------------------</div><div \
style="font-size:14px;font-family:Verdana;color:#000;"><div>Regards.</div> \
</div></sign></div><div>&nbsp;</div><div><includetail><div>&nbsp;</div><div>&nbsp;</div><div \
style="font:Verdana normal 14px;color:#000;"><div style="FONT-SIZE: 12px;FONT-FAMILY: \
Arial Narrow;padding:2px 0 2px \
0;">------------------&nbsp;Original&nbsp;------------------</div><div \
style="FONT-SIZE: 12px;background:#efefef;padding:8px;"><div \
id="menu_sender"><b>From: </b>&nbsp;"Vincent \
Povirk"&lt;madewokherd@gmail.com&gt;;</div><div><b>Date: </b>&nbsp;Tue, Dec 23, 2014 \
02:05 AM</div><div><b>To: </b>&nbsp;"Qian Hong"&lt;fracting@gmail.com&gt;; \
<wbr></div><div><b>Cc: </b>&nbsp;"Changhui Liu"&lt;liuchanghui@linuxdeepin.com&gt;; \
"wine-devel"&lt;wine-devel@winehq.org&gt;; <wbr></div><div><b>Subject: </b>&nbsp;Re: \
gdiplus: fix GdipFillRectangleI no effect on memoryDCwhosewindoworiginpointhas \
changed</div></div><div>&nbsp;</div>&gt; It seems the "new patch file" was not sent \
to public mailing list.<br>&gt; Changhui, would you mind resend your final patch to \
wine-patches?<br><br>That's odd. Wine-devel was CCed on the mail. Maybe the \
image<br>attachment made the email too large, and it was filtered.<br><br>They'll \
have to be sent to wine-patches anyway for proper review.<br><br>&gt; Also, Vincent, \
if you could suggest for a better commit message, that<br>&gt; would be nice :) You \
are native English speaker, neither I or Changhui<br>&gt; is native. But if the \
commit message looks good to you, then please<br>&gt; ignore me.<br><br>Ah, I sort of \
skipped over the commit messages, sorry. I would just<br>remove "no effect" from the \
third commit message, because there can be<br>an effect sometimes, it's just wrong. \
You could also remove the word<br>"error" from the first two.<br><br>The messages \
don't sound completely natural in English to me, but<br>there is also limited space, \
and I can't think of a way to make them<br>more natural without also making them \
longer or less descriptive.<br></div><!--<![endif]--></includetail></div>





[prev in list] [next in list] [prev in thread] [next in thread]