[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [2/2] shell32: Implement IApplicationAssociationRegistration, QueryCurrentDefault
From:       Nikolay Sivov <bunglehead () gmail ! com>
Date:       2014-09-29 3:58:13
Message-ID: 5428D8D5.4020302 () gmail ! com
[Download RAW message or body]

> +    hr = CoCreateInstance(&CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC_SERVER,
> +                          &IID_IApplicationAssociationRegistration, (LPVOID*)&appreg);
> +    if (FAILED(hr)) {
> +        skip("IApplicationAssociationRegistration not created: 0x%x\n", hr);
> +        return;
> +    }
Just check it with ok(), missing implementation is already checked in 
START_TEST().
> +    trace("%s\n", wine_dbgstr_w(assocprog));
Do you really need this?
> -    test_IApplicationAssociationRegistration_QueryInterface();
> +    /* this works since Vista */
> +    hr = CoCreateInstance(&CLSID_ApplicationAssociationRegistration, NULL, CLSCTX_INPROC_SERVER,
> +                          &IID_IApplicationAssociationRegistration, (LPVOID*)&appreg);
> +    if (hr == S_OK)
> +    {
> +        test_IApplicationAssociationRegistration_QueryInterface();
> +        test_IApplicationAssociationRegistration_QueryCurrentDefault();
> +
> +        IApplicationAssociationRegistration_Release(appreg);
> +    }
> +    else
> +        skip("IApplicationAssociationRegistration not supported: 0x%x\n", hr);
This should be win_skip().


[prev in list] [next in list] [prev in thread] [next in thread]