[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH 5/6] quartz: Fix race condition on EndFlush between csRenderLock and filter.csFilter.
From:       "Erich E. Hoover" <erich.e.hoover () gmail ! com>
Date:       2014-07-31 12:41:36
Message-ID: CAEU2+vo8t22kJzXs_fiJ3opK1q3shRLxxi1SkZAy=-av5ZTOGg () mail ! gmail ! com
[Download RAW message or body]

On Thu, Jul 31, 2014 at 5:51 AM, Michael Stefaniuc <mstefani@redhat.com> wrote:
> On 07/31/2014 03:48 AM, Erich E. Hoover wrote:
>> ...
>>          LeaveCriticalSection(&iface->csRenderLock);
>>          LeaveCriticalSection(&iface->filter.csFilter);
> Eric, shouldn't you release the inner lock first?

Absolutely, I caught that in patch 3 - can't believe I missed that
one, good catch!

Best,
Erich


[prev in list] [next in list] [prev in thread] [next in thread]