[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] bcrypt: Add stub for BCryptOpenAlgorithmProvider.
From:       Dmitry Timoshkov <dmitry () baikal ! ru>
Date:       2014-04-30 0:47:56
Message-ID: 20140430094756.2f319f9f.dmitry () baikal ! ru
[Download RAW message or body]

Alex Henrie <alexhenrie24@gmail.com> wrote:

> +@ stdcall BCryptOpenAlgorithmProvider(ptr ptr ptr long)

It should be (ptr wstr wstr long)

> +NTSTATUS WINAPI BCryptOpenAlgorithmProvider(BCRYPT_ALG_HANDLE *phAlgorithm, \
> LPCWSTR pszAlgId, +                                            LPCWSTR \
> pszImplementation, DWORD dwFlags) +{
> +    FIXME("%p, %s, %s, %08x - stub\n", phAlgorithm, wine_dbgstr_w(pszAlgId), \
> wine_dbgstr_w(pszImplementation), dwFlags); +
> +    *phAlgorithm = NULL;
> +
> +    return STATUS_NOT_IMPLEMENTED;
> +}

Probably there should be a test for NULL before writing to *phAlgorithm.

Also please avoid using hungarian notation for variable naming in Wine.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]