[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [patch]: include : Add missing API to direct-x 9's shader header
From:       Henri Verbeet <hverbeet () gmail ! com>
Date:       2014-01-29 10:00:49
Message-ID: CAOsNvwy=ig65SUOb=k3PpUUr7Mx7=JGxtfn0JhUp0Z+hcPykGg () mail ! gmail ! com
[Download RAW message or body]

On 28 January 2014 16:13, Kai Tietz <ktietz70@googlemail.com> wrote:
> Resent patch without inlining.
> 
Well, inline is prefered, but using git send-email makes it much
easier to not mess that up.

> +#define D3DXCONSTTABLE_LARGEADDRESSAWARE » · · · · · ·  0x20000
You have a stray tab here.

> -DEFINE_GUID(IID_ID3DXConstantTable, 0x9dca3190, 0x38b9, 0x4fc3, 0x92, 0xe3, 0x39, \
> 0xc6, 0xdd, 0xfb, 0x35, 0x8b); +DEFINE_GUID(IID_ID3DXConstantTable, 0xab3c758f, \
> 0x93e, 0x4356, 0xb7, 0x62, 0x4d, 0xb1, 0x8f, 0x1b, 0x3a, 0x1);
I may not have explicitly said this in my previous mail about this
patch, but I think the headers should be consistent. So if you make
this change, you can't keep D3DX_SDK_VERSION at 36. If you bump it to
43, there may be changes to other interfaces you need to make as well.
This could also have consequences for the actual implementation.

> +    STDMETHOD(GetConstantBuffer)(THIS_ LPD3DXBUFFER *ppConstantBuffer) PURE;
Please avoid names like "ppConstantBuffer" and typedefs like
LPD3DXBUFFER unless required for compatibility. So e.g.:
+    STDMETHOD(GetConstantBuffer)(THIS_ ID3DXBuffer **constant_buffer) PURE;


[prev in list] [next in list] [prev in thread] [next in thread]