[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: msvcrt: add support for _chsize_s (try #3)
From:       Piotr Caban <piotr.caban () gmail ! com>
Date:       2013-10-28 11:11:52
Message-ID: 526E4678.5030902 () gmail ! com
[Download RAW message or body]

Hi,

On 10/26/13 04:58, Mike Koss wrote:
> This patch adds the _chsize_s() to the mscvrt and corresponding mscvr*s.
> Incorporates previous feedback and now includes an updated test file.
>
> ---
>   dlls/msvcr100/msvcr100.spec |  2 +-
>   dlls/msvcr110/msvcr110.spec |  2 +-
>   dlls/msvcr80/msvcr80.spec   |  2 +-
>   dlls/msvcr90/msvcr90.spec   |  2 +-
>   dlls/msvcrt/file.c          | 63
> +++++++++++++++++++++++++++++++++++++++++++++
>   dlls/msvcrt/msvcrt.spec     |  2 +-
>   dlls/msvcrt/tests/file.c    | 37 ++++++++++++++++++++++++++
>   7 files changed, 105 insertions(+), 5 deletions(-)

There're few more issues with this patch:
  - _chsize_s is not defined in headers (please make sure that your code 
compiles without warnings)
  - _chsize_s is not available in some versions of msvcrt.dll, you 
should load it using GetProcAddress like in other *_s functions tests
  - the tests are failing on windows, it's probably also caused by lack 
of _chsize_s header

Thanks,
Piotr



[prev in list] [next in list] [prev in thread] [next in thread]