[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: kernel32/time: Implement GetSystemTimes for linux.
From:       Bernard Ladenthin <bernard () ladenthin ! net>
Date:       2013-09-29 20:52:11
Message-ID: 524892FB.4070304 () ladenthin ! net
[Download RAW message or body]

Am 29.09.2013 20:08, schrieb Andr=E9 Hentschel:
> Am 28.09.2013 21:51, schrieb Bernard Ladenthin:
>> ---
>>  dlls/kernel32/time.c |  149
>> ++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 149 insertions(+)
> =

> =

> Hi,
> please don't use C++ comments, also the rest of the coding style isn't of=
ten seen in Wine...
> (e.g. missing space between if/for/... and the bracket, your way of varia=
ble definig/initializing, most likely more)
> =

> maybe you also want to change the FIXME into something like "not implemen=
ted for this platform" and add a TRACE for the linux way.
> =

> =

> =


Hi, thanks for the feedback, I will write a new patch. Regards, Bernard


[prev in list] [next in list] [prev in thread] [next in thread]