[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: my patch was wrong at dlls/kernel32/computernames.c
From:       Marcus Meissner <meissner () suse ! de>
Date:       2013-08-29 14:35:39
Message-ID: 20130829143539.GB19640 () suse ! de
[Download RAW message or body]

On Thu, Aug 29, 2013 at 11:31:06PM +0900, matyapiro31 wrote:
> From
> if ( isalnumW ( wc ) ) return wc;
> for ( i = 0; i < 17; i++ )
> To
> if ( isalnumW ( wc ) ) return wc;
> for ( i = 0; i < 16; i++ )
> and the original version was wrong,too.
> It counts the NULL of the end.

Thats why you should use sizeof() or strlen() ... and not hardcoded magic values.

CIao, Marcus


[prev in list] [next in list] [prev in thread] [next in thread]