[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: ws2_32/tests: Test the precedence of parameters while creating a socket in WSASocket()
From:       Bruno Jesus <00cpxxx () gmail ! com>
Date:       2013-07-31 18:25:14
Message-ID: CALF_nUSR-my8hYjNbbq2Hpnr19k_7377-Q3VFYFZXU1LDU8idQ () mail ! gmail ! com
[Download RAW message or body]

On Wed, Jul 31, 2013 at 10:21 AM, Thomas Faber <thfabba@gmx.de> wrote:
> On 2013-07-31 02:48, Bruno Jesus wrote:
> > +    ok(!getsockopt(sock, SOL_SOCKET, SO_TYPE, (char *) &socktype, &size), \
> > "getsockopt failed with %d\n", +       WSAGetLastError());
> 
> It's not guaranteed that getsockopt is called before WSAGetLastError
> here. (in fact the latter will be evaluated first with most practically
> used calling conventions)
> So this needs a variable.

I see, thanks. Unfortunately previous patches already introduced that
in 5 other places. If the patch is not commited today I'll change all
older issues and send a new version fixing this. If the patch is
commited today I'll send another patch fixing the 6 places.

> Best,
> Thomas

Best wishes,
Bruno


[prev in list] [next in list] [prev in thread] [next in thread]