[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH] advapi32: RegDeleteKey tests
From:       Dmitry Timoshkov <dmitry () baikal ! ru>
Date:       2013-06-25 3:46:15
Message-ID: 20130625124615.6929a661.dmitry () baikal ! ru
[Download RAW message or body]

George Stephanos <gaf.stephanos@gmail.com> wrote:

> +    res = RegOpenKeyExA( hkey, "subkey1", 0, KEY_READ, &hkeysub1 );
> +    ok(res != ERROR_SUCCESS, "test key found in user's classes: %d\n", res);
...
> +    res = RegOpenKeyExA( hklm, "subkey1", 0, KEY_READ, &hklmsub1 );
> +    ok(res != ERROR_SUCCESS, "test key found in hklm: %d\n", res);

Testing for res != ERROR_SUCCESS is not very useful, please check for
a particular error code. Also please close successfully opened handles.

-- 
Dmitry.


[prev in list] [next in list] [prev in thread] [next in thread]