[prev in list] [next in list] [prev in thread] [next in thread] 

List:       wine-devel
Subject:    Re: [PATCH]winhttp:session.c fix a bug(return value is null)
From:       Hans Leidekker <hans () codeweavers ! com>
Date:       2013-06-24 11:17:58
Message-ID: 1372072678.5015.20.camel () t400
[Download RAW message or body]

On Mon, 2013-06-24 at 19:57 +0900, 中川祥 wrote:
> diff --git a/dlls/winhttp/session.c b/dlls/winhttp/session.c
> index 660eae5..dfe23d4 100644
> --- a/dlls/winhttp/session.c
> +++ b/dlls/winhttp/session.c
> @@ -1316,6 +1316,8 @@ BOOL WINAPI WinHttpDetectAutoProxyConfigUrl( DWORD flags, LPWSTR *url )
>      {
>          static int fixme_shown;
>          if (!fixme_shown++) FIXME("discovery via DHCP not supported\n");
> +        flags = WINHTTP_AUTO_DETECT_TYPE_DNS_A;
> +        ret=TRUE;
>      }
>      if (flags & WINHTTP_AUTO_DETECT_TYPE_DNS_A)
>      { 

We shouldn't perform DNS detection if the app didn't ask for it. Do you have an app
that fails because we return an error here?





[prev in list] [next in list] [prev in thread] [next in thread]